Pr Ready

Local diagnostics and tests before opening a PR.

Skill metadata

Source	Bundled (installed by default)
Path	skills/software-development/pr-ready
Version	1.0.0
Author	VibeOS
License	MIT
Platforms	linux, macos, windows
Tags	project, pr, diagnostics, tests, ready, gate
Related skills	change-impact, codebase-navigate, requesting-code-review, git-local-workflow, pr-babysit

Reference: full SKILL.md

信息

The following is the complete skill definition that VibeOS loads when this skill is triggered. This is what the agent sees as instructions when the skill is active.

PR Ready Skill

Local go/no-go before gh pr create / push. Uses Project Intelligence CLI + discovered test commands — no new core tools. Drive with terminal.

Does not replace live review (requesting-code-review) or CI babysit (pr-babysit). This is the offline gate on the operator machine.

When to Use

• User asks “ready for PR?”, “can we open a PR?”, “ship checklist”
• After change-impact summary looks acceptable
• Before first push of a feature branch

Skip when: user forbids running tests; change is docs-only and they say skip.

Prerequisites

• Git repo; prefer clean index (or intentional staged set)
• vibeos pack apply project-intelligence --apply once per project
• For this monorepo: prefer scripts/run_tests.sh over bare pytest

How to Run

1. Offline gate helper (same skill directory):

python3 skills/software-development/pr-ready/scripts/pr_ready_check.py
# JSON:
python3 skills/software-development/pr-ready/scripts/pr_ready_check.py --json

Exit 0 = index ok + diagnostics cache has zero errors (warnings OK). Exit 1 = fix listed gaps first.

2. Or run the probes manually:

vibeos doctor --project
vibeos project index status
vibeos project diagnostics
vibeos project commands

3. Run the primary test command from commands.json / doctor hint. In VibeOS itself:

scripts/run_tests.sh <touched-tests> -q

4. Optional pre-commit review skill: load requesting-code-review on the diff. Then open PR via github-pr-workflow / babysit with pr-babysit.

Quick Reference

Goal	Command
Gate script	…/pr-ready/scripts/pr_ready_check.py
Doctor	vibeos doctor --project
Index	vibeos project index status
Diagnostics	vibeos project diagnostics --show
Test cmds	vibeos project commands
Blast radius	skill change-impact

Procedure

1. Fail closed on PROJ.index_missing / PROJ.index_stale — rebuild first.
2. Fail closed on diagnostics errors (not warnings).
3. Run at least primary_test (or a focused subset for huge suites).
4. Confirm no secrets in the diff (.env, credentials) before push.
5. Only then create the PR; CI failures → pr-babysit.

Pitfalls

• Helper reads the cached diagnostics file — refresh with vibeos project diagnostics if the tree moved.
• Unbounded test suites: use focused paths; do not burn the session.
• Push/PR still need user policy allow (VIBEOS_POLICY_ALLOW_GITHUB).

Verification

python3 skills/software-development/pr-ready/scripts/pr_ready_check.py
vibeos doctor --project